Mesa (master): meta: Fix error paths in meta_copy_image.c
Tapani Pälli
tpalli at kemper.freedesktop.org
Tue Sep 23 07:52:10 UTC 2014
Module: Mesa
Branch: master
Commit: b9463813eeffbe3b03fbf681d0283a40ce84619a
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b9463813eeffbe3b03fbf681d0283a40ce84619a
Author: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
Date: Mon Sep 8 13:59:50 2014 +0300
meta: Fix error paths in meta_copy_image.c
If _mesa_get_tex_image() return NULL there is already error
set in context. Other error pats free allocated texture.
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>
---
src/mesa/drivers/common/meta_copy_image.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/src/mesa/drivers/common/meta_copy_image.c b/src/mesa/drivers/common/meta_copy_image.c
index 0c204b8..fc0cbaf 100644
--- a/src/mesa/drivers/common/meta_copy_image.c
+++ b/src/mesa/drivers/common/meta_copy_image.c
@@ -63,12 +63,21 @@ make_view(struct gl_context *ctx, struct gl_texture_image *tex_image,
if (!ctx->Driver.TestProxyTexImage(ctx, tex_obj->Target, 0, tex_format,
tex_image->Width, tex_image->Height,
tex_image->Depth, 0)) {
+ _mesa_DeleteTextures(1, view_tex_name);
+ *view_tex_name = 0;
return false;
}
view_tex_obj->Target = tex_obj->Target;
*view_tex_image = _mesa_get_tex_image(ctx, view_tex_obj, tex_obj->Target, 0);
+
+ if (!*view_tex_image) {
+ _mesa_DeleteTextures(1, view_tex_name);
+ *view_tex_name = 0;
+ return false;
+ }
+
_mesa_init_teximage_fields(ctx, *view_tex_image,
tex_image->Width, tex_image->Height,
tex_image->Depth,
More information about the mesa-commit
mailing list