Mesa (master): mesa: Set correct array element in vbo_exec_vtx_init.

Kenneth Graunke kwg at kemper.freedesktop.org
Thu Sep 25 06:12:35 UTC 2014


Module: Mesa
Branch: master
Commit: f81052dc9b99eca765a44decd01af0335350d0b2
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f81052dc9b99eca765a44decd01af0335350d0b2

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Sun Sep 14 23:45:38 2014 -0700

mesa: Set correct array element in vbo_exec_vtx_init.

I'm not familiar with this code, but this sure appears to be a typo.
It looks like the intent is to set each array element, not arrays[0]
each time.  Notably, the loop just below uses "array", not "arrays".

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Fredrik Höglund <fredrik at kde.org>
Reviewed-by: Brian Paul <brianp at vmware.com>
Cc: mesa-stable at lists.freedesktop.org

---

 src/mesa/vbo/vbo_exec_api.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/vbo/vbo_exec_api.c b/src/mesa/vbo/vbo_exec_api.c
index 74aec12..2871100 100644
--- a/src/mesa/vbo/vbo_exec_api.c
+++ b/src/mesa/vbo/vbo_exec_api.c
@@ -1067,7 +1067,7 @@ void vbo_exec_vtx_init( struct vbo_exec_context *exec )
          struct gl_client_array *array;
          array = &arrays[VERT_ATTRIB_FF(i)];
          array->BufferObj = NULL;
-         _mesa_reference_buffer_object(ctx, &arrays->BufferObj,
+         _mesa_reference_buffer_object(ctx, &array->BufferObj,
                                  vbo->currval[VBO_ATTRIB_POS+i].BufferObj);
       }
 




More information about the mesa-commit mailing list