Mesa (master): mesa: Returns a GL_INVALID_VALUE error if num of fbos in glDeleteRenderbuffers is negative
Iago Toral Quiroga
itoral at kemper.freedesktop.org
Tue Jan 13 11:20:27 UTC 2015
Module: Mesa
Branch: master
Commit: 2012f62d4abb6633b5329235194d23692f86b17b
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2012f62d4abb6633b5329235194d23692f86b17b
Author: Eduardo Lima Mitev <elima at igalia.com>
Date: Thu Dec 11 23:34:18 2014 +0100
mesa: Returns a GL_INVALID_VALUE error if num of fbos in glDeleteRenderbuffers is negative
Per GLES3 manual for glDeleteRenderbuffers
<https://www.khronos.org/opengles/sdk/docs/man3/html/glDeleteRenderbuffers.xhtml>,
GL_INVALID_VALUE is generated if n is negative.
Fixes 1 dEQP test:
* dEQP-GLES3.functional.negative_api.buffer.delete_renderbuffers
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
---
src/mesa/main/fbobject.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index d0f19d0..c5dd037 100644
--- a/src/mesa/main/fbobject.c
+++ b/src/mesa/main/fbobject.c
@@ -1311,6 +1311,11 @@ _mesa_DeleteRenderbuffers(GLsizei n, const GLuint *renderbuffers)
GLint i;
GET_CURRENT_CONTEXT(ctx);
+ if (n < 0) {
+ _mesa_error(ctx, GL_INVALID_VALUE, "glDeleteRenderbuffers(n < 0)");
+ return;
+ }
+
FLUSH_VERTICES(ctx, _NEW_BUFFERS);
for (i = 0; i < n; i++) {
More information about the mesa-commit
mailing list