Mesa (master): glsl: Initialize parse-state in constructor of lower_subroutine.

Matt Turner mattst88 at kemper.freedesktop.org
Fri Jul 31 17:30:26 UTC 2015


Module: Mesa
Branch: master
Commit: 616355160d3ee6edff3429b1abef82f0706dad3d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=616355160d3ee6edff3429b1abef82f0706dad3d

Author: Matt Turner <mattst88 at gmail.com>
Date:   Wed Jul 29 10:47:51 2015 -0700

glsl: Initialize parse-state in constructor of lower_subroutine.

Static analysis tools don't like partial object initializations.

Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>

---

 src/glsl/lower_subroutine.cpp |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/glsl/lower_subroutine.cpp b/src/glsl/lower_subroutine.cpp
index e45ccfe..b29912a 100644
--- a/src/glsl/lower_subroutine.cpp
+++ b/src/glsl/lower_subroutine.cpp
@@ -37,7 +37,8 @@ namespace {
 
 class lower_subroutine_visitor : public ir_hierarchical_visitor {
 public:
-   lower_subroutine_visitor()
+   lower_subroutine_visitor(struct _mesa_glsl_parse_state *state)
+      : state(state)
    {
       this->progress = false;
    }
@@ -52,8 +53,7 @@ public:
 bool
 lower_subroutine(exec_list *instructions, struct _mesa_glsl_parse_state *state)
 {
-   lower_subroutine_visitor v;
-   v.state = state;
+   lower_subroutine_visitor v(state);
    visit_list_elements(&v, instructions);
    return v.progress;
 }




More information about the mesa-commit mailing list