Mesa (master): i965/cfg: Assert that cur_do/while/ if pointers are non-NULL.
Matt Turner
mattst88 at kemper.freedesktop.org
Tue Jun 23 19:48:48 UTC 2015
Module: Mesa
Branch: master
Commit: 4d93a07c45c8aa4cb3adbfcb9d61dcb54d8c404f
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4d93a07c45c8aa4cb3adbfcb9d61dcb54d8c404f
Author: Matt Turner <mattst88 at gmail.com>
Date: Mon Jun 22 11:09:49 2015 -0700
i965/cfg: Assert that cur_do/while/if pointers are non-NULL.
Coverity sees that the functions immediately below the new assertions
dereference these pointers, but is unaware that an ENDIF always follows
an IF, etc.
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
---
src/mesa/drivers/dri/i965/brw_cfg.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_cfg.cpp b/src/mesa/drivers/dri/i965/brw_cfg.cpp
index 39c419b..f1f230e 100644
--- a/src/mesa/drivers/dri/i965/brw_cfg.cpp
+++ b/src/mesa/drivers/dri/i965/brw_cfg.cpp
@@ -231,6 +231,7 @@ cfg_t::cfg_t(exec_list *instructions)
if (cur_else) {
cur_else->add_successor(mem_ctx, cur_endif);
} else {
+ assert(cur_if != NULL);
cur_if->add_successor(mem_ctx, cur_endif);
}
@@ -299,6 +300,7 @@ cfg_t::cfg_t(exec_list *instructions)
inst->exec_node::remove();
cur->instructions.push_tail(inst);
+ assert(cur_do != NULL && cur_while != NULL);
cur->add_successor(mem_ctx, cur_do);
set_next_block(&cur, cur_while, ip);
More information about the mesa-commit
mailing list