Mesa (master): i965/fs: Do the no16 perf logging directly in fs_visitor:: no16()

Jason Ekstrand jekstrand at kemper.freedesktop.org
Tue Jun 23 22:36:48 UTC 2015


Module: Mesa
Branch: master
Commit: 3fd457c9ddd4b9f730e70bfd19b2f9eeeeaef089
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3fd457c9ddd4b9f730e70bfd19b2f9eeeeaef089

Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Mon Jun 22 16:32:06 2015 -0700

i965/fs: Do the no16 perf logging directly in fs_visitor::no16()

While we're at it, we'll drop the note about 10-20% performance loss.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>

---

 src/mesa/drivers/dri/i965/brw_fs.cpp |   13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 5d18dda..3b311ca 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
@@ -710,12 +710,7 @@ fs_visitor::no16(const char *msg)
    } else {
       simd16_unsupported = true;
 
-      if (brw->perf_debug) {
-         if (no16_msg)
-            ralloc_strcat(&no16_msg, msg);
-         else
-            no16_msg = ralloc_strdup(mem_ctx, msg);
-      }
+      perf_debug("SIMD16 shader failed to compile: %s", msg);
    }
 }
 
@@ -4054,14 +4049,10 @@ brw_wm_fs_emit(struct brw_context *brw,
          /* Try a SIMD16 compile */
          v2.import_uniforms(&v);
          if (!v2.run_fs()) {
-            perf_debug("SIMD16 shader failed to compile, falling back to "
-                       "SIMD8 at a 10-20%% performance cost: %s", v2.fail_msg);
+            perf_debug("SIMD16 shader failed to compile: %s", v2.fail_msg);
          } else {
             simd16_cfg = v2.cfg;
          }
-      } else {
-         perf_debug("SIMD16 shader unsupported, falling back to "
-                    "SIMD8 at a 10-20%% performance cost: %s", v.no16_msg);
       }
    }
 




More information about the mesa-commit mailing list