Mesa (master): st/mesa: remove unneeded pipe_surface_release() in st_render_texture()
Brian Paul
brianp at kemper.freedesktop.org
Wed Jun 24 13:19:45 UTC 2015
Module: Mesa
Branch: master
Commit: c1de7df6d4086070e63369ab0af3950f53a03592
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c1de7df6d4086070e63369ab0af3950f53a03592
Author: Brian Paul <brianp at vmware.com>
Date: Mon Jun 22 14:04:09 2015 -0600
st/mesa: remove unneeded pipe_surface_release() in st_render_texture()
This caused us to always free the pipe_surface for the renderbuffer.
The subsequent call to st_update_renderbuffer_surface() would typically
just recreate it. Remove the call to pipe_surface_release() and let
st_update_renderbuffer_surface() take care of freeing the old surface
if it needs to be replaced (because of change to mipmap level, etc).
This can save quite a few calls to pipe_context::create_surface() and
surface_destroy().
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
---
src/mesa/state_tracker/st_cb_fbo.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c
index 0399eef..5707590 100644
--- a/src/mesa/state_tracker/st_cb_fbo.c
+++ b/src/mesa/state_tracker/st_cb_fbo.c
@@ -511,8 +511,6 @@ st_render_texture(struct gl_context *ctx,
strb->rtt_layered = att->Layered;
pipe_resource_reference(&strb->texture, pt);
- pipe_surface_release(pipe, &strb->surface);
-
st_update_renderbuffer_surface(st, strb);
strb->Base.Format = st_pipe_format_to_mesa_format(pt->format);
More information about the mesa-commit
mailing list