Mesa (master): i965: Don't use GCC extension for ?: with only two operands.

Kenneth Graunke kwg at kemper.freedesktop.org
Tue Jun 30 05:23:26 UTC 2015


Module: Mesa
Branch: master
Commit: 21b7c58b8a0cbf18c9ed90c260f01d00fefe0db2
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=21b7c58b8a0cbf18c9ed90c260f01d00fefe0db2

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Tue Jun 23 23:57:31 2015 -0700

i965: Don't use GCC extension for ?: with only two operands.

>From the "apparently I don't know C" files...GCC apparently supports:

    x ?: y

which is equivalent to

    x ? x : y

except that it doesn't cause side-effects to occur twice.  See:
https://gcc.gnu.org/onlinedocs/gcc/Conditionals.html#Conditionals

This was confusing and looked like a typo.  It doesn't really buy us
anything, so just write the obvious code in normal C.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>

---

 src/mesa/drivers/dri/i965/intel_fbo.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c b/src/mesa/drivers/dri/i965/intel_fbo.c
index 9e6a711..05e3f8b 100644
--- a/src/mesa/drivers/dri/i965/intel_fbo.c
+++ b/src/mesa/drivers/dri/i965/intel_fbo.c
@@ -551,10 +551,12 @@ intel_renderbuffer_update_wrapper(struct brw_context *brw,
 
    irb->mt_layer = layer_multiplier * layer;
 
-   if (layered) {
-      irb->layer_count = image->TexObject->NumLayers ?: mt->level[level].depth / layer_multiplier;
-   } else {
+   if (!layered) {
       irb->layer_count = 1;
+   } else if (image->TexObject->NumLayers > 0) {
+      irb->layer_count = image->TexObject->NumLayers;
+   } else {
+      irb->layer_count = mt->level[level].depth / layer_multiplier;
    }
 
    intel_miptree_reference(&irb->mt, mt);




More information about the mesa-commit mailing list