Mesa (master): i965/fs: Fix fs_inst::regs_read() for uniform pull constant loads

Jason Ekstrand jekstrand at kemper.freedesktop.org
Tue Jun 30 23:48:22 UTC 2015


Module: Mesa
Branch: master
Commit: aca5228011e7b9e96f3bd3a621c88e63ba47a4f3
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=aca5228011e7b9e96f3bd3a621c88e63ba47a4f3

Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Wed Jun 17 18:02:11 2015 -0700

i965/fs: Fix fs_inst::regs_read() for uniform pull constant loads

Previously, fs_inst::regs_read() fell back to depending on the register
width for the second source.  This isn't really correct since it isn't a
SIMD8 value at all, but a SIMD4x2 value.  This commit changes it to
explicitly be always one register.

v2: Use mlen for determining the number of registers read

Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
Acked-by: Francisco Jerez <currojerez at riseup.net>

---

 src/mesa/drivers/dri/i965/brw_fs.cpp |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 94f4294..e83a092 100644
--- a/src/mesa/drivers/dri/i965/brw_fs.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
@@ -715,6 +715,12 @@ fs_inst::regs_read(int arg) const
          return mlen;
       break;
 
+   case FS_OPCODE_UNIFORM_PULL_CONSTANT_LOAD_GEN7:
+      /* The payload is actually stored in src1 */
+      if (arg == 1)
+         return mlen;
+      break;
+
    case FS_OPCODE_LINTERP:
       if (arg == 0)
          return exec_size / 4;




More information about the mesa-commit mailing list