Mesa (master): mesa/main: validate name syntax for array variables only

Samuel Iglesias Gonsálvez samuelig at kemper.freedesktop.org
Wed May 20 06:06:07 UTC 2015


Module: Mesa
Branch: master
Commit: 4ee69a97bb0af0cc216539c48b246ea2abf8f208
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4ee69a97bb0af0cc216539c48b246ea2abf8f208

Author: Samuel Iglesias Gonsalvez <siglesias at igalia.com>
Date:   Wed May 13 12:18:31 2015 +0200

mesa/main: validate name syntax for array variables only

>From ARB_program_interface_query:

 "Note that if an interface enumerates a single active resource list
 entry for an array variable (e.g., "a[0]"), a <name> identifying
 any array element other than the first (e.g., "a[1]") is not
 considered to match."

It doesn't apply to arrays of interface blocks but just to array
variables.

Signed-off-by: Samuel Iglesias Gonsalvez <siglesias at igalia.com>
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

---

 src/mesa/main/program_resource.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mesa/main/program_resource.c b/src/mesa/main/program_resource.c
index b15a132..d857b84 100644
--- a/src/mesa/main/program_resource.c
+++ b/src/mesa/main/program_resource.c
@@ -220,12 +220,12 @@ _mesa_GetProgramResourceIndex(GLuint program, GLenum programInterface,
    case GL_PROGRAM_INPUT:
    case GL_PROGRAM_OUTPUT:
    case GL_UNIFORM:
-   case GL_UNIFORM_BLOCK:
    case GL_TRANSFORM_FEEDBACK_VARYING:
-      /* Validate name syntax for arrays. */
+      /* Validate name syntax for array variables */
       if (!valid_program_resource_index_name(name))
          return GL_INVALID_INDEX;
-
+      /* fall-through */
+   case GL_UNIFORM_BLOCK:
       res = _mesa_program_resource_find_name(shProg, programInterface, name);
       if (!res)
          return GL_INVALID_INDEX;




More information about the mesa-commit mailing list