Mesa (master): docs: add information about reviewing patches

Brian Paul brianp at kemper.freedesktop.org
Tue May 26 18:21:32 UTC 2015


Module: Mesa
Branch: master
Commit: 2ab0ca36c155cc77e3d5c950270c70a24efee3d3
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2ab0ca36c155cc77e3d5c950270c70a24efee3d3

Author: Brian Paul <brianp at vmware.com>
Date:   Tue May 26 11:30:22 2015 -0600

docs: add information about reviewing patches

Reviewed-by: Matt Turner <mattst88 at gmail.com>

---

 docs/devinfo.html |   25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/docs/devinfo.html b/docs/devinfo.html
index f5113b0..eb3aba1 100644
--- a/docs/devinfo.html
+++ b/docs/devinfo.html
@@ -266,6 +266,31 @@ re-sending the whole series). Using --in-reply-to makes
 it harder for reviewers to accidentally review old patches.
 </p>
 
+<h3>Reviewing Patches</h3>
+
+<p>
+When you've reviewed a patch on the mailing list, please be unambiguous
+about your review.  That is, state either
+<pre>
+    Reviewed-by: Joe Hacker <jhacker at foo.com>
+</pre>
+or
+<pre>
+    Acked-by: Joe Hacker <jhacker at foo.com>
+</pre>
+Rather than saying just "LGTM" or "Seems OK".
+</p>
+
+<p>
+If small changes are suggested, it's OK to say something like:
+<pre>
+   With the above fixes, Reviewed-by: Joe Hacker <jhacker at foo.com>
+</pre>
+which tells the patch author that the patch can be committed, as long
+as the issues are resolved first.
+</p>
+
+
 <h3>Marking a commit as a candidate for a stable branch</h3>
 
 <p>




More information about the mesa-commit mailing list