Mesa (master): vc4: Don't bother with safe list traversal in CSE.

Eric Anholt anholt at kemper.freedesktop.org
Sat May 30 05:57:30 UTC 2015


Module: Mesa
Branch: master
Commit: ec1c72d38ea4c709a39c6be9e0ff96bc2a90940f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ec1c72d38ea4c709a39c6be9e0ff96bc2a90940f

Author: Eric Anholt <eric at anholt.net>
Date:   Fri May 29 21:27:53 2015 -0700

vc4: Don't bother with safe list traversal in CSE.

We don't remove or move instructions.

---

 src/gallium/drivers/vc4/vc4_opt_cse.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/vc4/vc4_opt_cse.c b/src/gallium/drivers/vc4/vc4_opt_cse.c
index 27d0fae..92c8260 100644
--- a/src/gallium/drivers/vc4/vc4_opt_cse.c
+++ b/src/gallium/drivers/vc4/vc4_opt_cse.c
@@ -128,7 +128,7 @@ qir_opt_cse(struct vc4_compile *c)
         if (!ht)
                 return false;
 
-        list_for_each_entry_safe(struct qinst, inst, &c->instructions, link) {
+        list_for_each_entry(struct qinst, inst, &c->instructions, link) {
                 if (qir_has_side_effects(c, inst) ||
                     qir_has_side_effect_reads(c, inst)) {
                         continue;




More information about the mesa-commit mailing list