Mesa (master): glsl: OpenGLES GLSL 3.1 precision qualifiers ordering rules

Jordan Justen jljusten at kemper.freedesktop.org
Sun Nov 1 06:24:58 UTC 2015


Module: Mesa
Branch: master
Commit: 218e94906d877889b2b124187d8e17b7f0879122
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=218e94906d877889b2b124187d8e17b7f0879122

Author: Jordan Justen <jordan.l.justen at intel.com>
Date:   Thu Oct 15 14:47:34 2015 -0700

glsl: OpenGLES GLSL 3.1 precision qualifiers ordering rules

The OpenGLES GLSL 3.1 specification uses the precision qualifier
ordering rules from ARB_shading_language_420pack.

Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
Reviewed-by: Marta Lofstedt <marta.lofstedt at intel.com>

---

 src/glsl/glsl_parser.yy |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy
index 2f2e10d..4636435 100644
--- a/src/glsl/glsl_parser.yy
+++ b/src/glsl/glsl_parser.yy
@@ -948,7 +948,8 @@ parameter_qualifier:
       if ($2.precision != ast_precision_none)
          _mesa_glsl_error(&@1, state, "duplicate precision qualifier");
 
-      if (!state->has_420pack() && $2.flags.i != 0)
+      if (!(state->has_420pack() || state->is_version(420, 310)) &&
+          $2.flags.i != 0)
          _mesa_glsl_error(&@1, state, "precision qualifiers must come last");
 
       $$ = $2;
@@ -1847,7 +1848,8 @@ type_qualifier:
       if ($2.precision != ast_precision_none)
          _mesa_glsl_error(&@1, state, "duplicate precision qualifier");
 
-      if (!state->has_420pack() && $2.flags.i != 0)
+      if (!(state->has_420pack() || state->is_version(420, 310)) &&
+          $2.flags.i != 0)
          _mesa_glsl_error(&@1, state, "precision qualifiers must come last");
 
       $$ = $2;




More information about the mesa-commit mailing list