Mesa (master): i965: Use brw_reg's nr field to store register number.

Matt Turner mattst88 at kemper.freedesktop.org
Fri Nov 13 19:58:07 UTC 2015


Module: Mesa
Branch: master
Commit: 7638e75cf99263c1ee8e31c6cc5a319feec2c943
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7638e75cf99263c1ee8e31c6cc5a319feec2c943

Author: Matt Turner <mattst88 at gmail.com>
Date:   Mon Oct 26 04:35:14 2015 -0700

i965: Use brw_reg's nr field to store register number.

In addition to combining another field, we get replace silliness like
"reg.reg" with something that actually makes sense, "reg.nr"; and no one
will ever wonder again why dst.reg isn't a dst_reg.

Moving the now 16-bit nr field to a 16-bit boundary decreases code size
by about 3k.

Reviewed-by: Emil Velikov <emil.velikov at collabora.co.uk>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/mesa/drivers/dri/i965/brw_fs.cpp               |  163 ++++++++++----------
 .../drivers/dri/i965/brw_fs_combine_constants.cpp  |    8 +-
 .../drivers/dri/i965/brw_fs_copy_propagation.cpp   |   18 +--
 src/mesa/drivers/dri/i965/brw_fs_cse.cpp           |    2 +-
 src/mesa/drivers/dri/i965/brw_fs_generator.cpp     |    8 +-
 src/mesa/drivers/dri/i965/brw_fs_live_variables.h  |    2 +-
 src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp  |   34 ++--
 .../drivers/dri/i965/brw_fs_register_coalesce.cpp  |   22 +--
 .../dri/i965/brw_fs_saturate_propagation.cpp       |    2 +-
 src/mesa/drivers/dri/i965/brw_fs_validate.cpp      |    4 +-
 src/mesa/drivers/dri/i965/brw_fs_visitor.cpp       |    2 +-
 src/mesa/drivers/dri/i965/brw_ir_fs.h              |    6 +-
 src/mesa/drivers/dri/i965/brw_ir_vec4.h            |    8 +-
 src/mesa/drivers/dri/i965/brw_reg.h                |   10 +-
 .../drivers/dri/i965/brw_schedule_instructions.cpp |   62 ++++----
 src/mesa/drivers/dri/i965/brw_shader.cpp           |    2 +-
 src/mesa/drivers/dri/i965/brw_shader.h             |    9 --
 src/mesa/drivers/dri/i965/brw_vec4.cpp             |  100 ++++++------
 .../drivers/dri/i965/brw_vec4_copy_propagation.cpp |    6 +-
 src/mesa/drivers/dri/i965/brw_vec4_cse.cpp         |    2 +-
 .../drivers/dri/i965/brw_vec4_live_variables.h     |   12 +-
 .../drivers/dri/i965/brw_vec4_reg_allocate.cpp     |   36 ++---
 src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp     |   40 ++---
 .../dri/i965/test_vec4_copy_propagation.cpp        |    4 +-
 .../dri/i965/test_vec4_register_coalesce.cpp       |    4 +-
 25 files changed, 276 insertions(+), 290 deletions(-)

Diff:   http://cgit.freedesktop.org/mesa/mesa/diff/?id=7638e75cf99263c1ee8e31c6cc5a319feec2c943



More information about the mesa-commit mailing list