Mesa (master): glsl: call set_shader_inout_layout() earlier
Timothy Arceri
tarceri at kemper.freedesktop.org
Fri Nov 20 20:30:29 UTC 2015
Module: Mesa
Branch: master
Commit: 4196af4ce7cdb0217a7cc6e196b1a788d32c5b6f
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4196af4ce7cdb0217a7cc6e196b1a788d32c5b6f
Author: Timothy Arceri <timothy.arceri at collabora.com>
Date: Sat Nov 14 14:05:30 2015 +1100
glsl: call set_shader_inout_layout() earlier
This will allow us to add error checking to this function
in a later patch, if we don't move it the error messages
will go missing.
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
---
src/glsl/glsl_parser_extras.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp
index c54dcfd..13a3c94 100644
--- a/src/glsl/glsl_parser_extras.cpp
+++ b/src/glsl/glsl_parser_extras.cpp
@@ -1799,6 +1799,9 @@ _mesa_glsl_compile_shader(struct gl_context *ctx, struct gl_shader *shader,
if (shader->InfoLog)
ralloc_free(shader->InfoLog);
+ if (!state->error)
+ set_shader_inout_layout(shader, state);
+
shader->symbols = new(shader->ir) glsl_symbol_table;
shader->CompileStatus = !state->error;
shader->InfoLog = state->info_log;
@@ -1806,9 +1809,6 @@ _mesa_glsl_compile_shader(struct gl_context *ctx, struct gl_shader *shader,
shader->IsES = state->es_shader;
shader->uses_builtin_functions = state->uses_builtin_functions;
- if (!state->error)
- set_shader_inout_layout(shader, state);
-
/* Retain any live IR, but trash the rest. */
reparent_ir(shader->ir, shader->ir);
More information about the mesa-commit
mailing list