Mesa (master): freedreno/a4xx: point regid to "red" even for alpha-only rb formats

Ilia Mirkin imirkin at kemper.freedesktop.org
Sat Nov 21 01:06:48 UTC 2015


Module: Mesa
Branch: master
Commit: ff9450ecd1f7635f8917e3177f0ef18eb8f9f49b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ff9450ecd1f7635f8917e3177f0ef18eb8f9f49b

Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date:   Fri Nov 20 18:11:26 2015 -0500

freedreno/a4xx: point regid to "red" even for alpha-only rb formats

Looks like a4xx hw does this in a more standard way and we don't need to
hack around it like we do on a3xx. Fixes GL_ALPHA formats in
fbo-blending-formats, fbo-colormask-formats, and fbo-alphatest-formats.

Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Cc: mesa-stable at lists.freedesktop.org

---

 src/gallium/drivers/freedreno/a4xx/fd4_program.c |    7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/gallium/drivers/freedreno/a4xx/fd4_program.c b/src/gallium/drivers/freedreno/a4xx/fd4_program.c
index e3d5dab..3df1354 100644
--- a/src/gallium/drivers/freedreno/a4xx/fd4_program.c
+++ b/src/gallium/drivers/freedreno/a4xx/fd4_program.c
@@ -245,13 +245,6 @@ fd4_program_emit(struct fd_ringbuffer *ring, struct fd4_emit *emit,
 		color_regid[7] = ir3_find_output_regid(s[FS].v, FRAG_RESULT_DATA7);
 	}
 
-	/* adjust regids for alpha output formats. there is no alpha render
-	 * format, so it's just treated like red
-	 */
-	for (i = 0; i < nr; i++)
-		if (util_format_is_alpha(pipe_surface_format(bufs[i])))
-			color_regid[i] += 3;
-
 	/* TODO get these dynamically: */
 	face_regid = s[FS].v->frag_face ? regid(0,0) : regid(63,0);
 	coord_regid = s[FS].v->frag_coord ? regid(0,0) : regid(63,0);




More information about the mesa-commit mailing list