Mesa (11.0): 22 new commits
Emil Velikov
evelikov at kemper.freedesktop.org
Thu Sep 24 10:24:00 UTC 2015
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cf716563a8a1f9704b8cc89b66d488b689ba82ab
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Mon Sep 14 11:59:22 2015 -0700
t_dd_dmatmp: Use addition instead of subtraction in loop bounds
This is used everywhere else in this file because it avoids problems
when count is zero (due to trimming).
No piglit regressions on i915 (G33) or radeon (Radeon 7500).
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38109
Reviewed-by: Brian Paul <brianp at vmware.com>
Cc: Marius Predut <marius.predut at intel.com>
Cc: "10.6 11.0" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 25543d8ec506ef32599af6f5e0dd735e01b39909)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2c65e64881045f99555c5fa7cc8284e2075d7383
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Mon Sep 14 11:56:20 2015 -0700
t_dd_dmatmp: Pull out common 'count -= count & 3' code
This was missing in the HAVE_TRIANGLES path, and that could cause
incorrect rendering.
No piglit regressions on i915 (G33) or radeon (Radeon 7500).
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38109
Reviewed-by: Brian Paul <brianp at vmware.com>
Cc: Marius Predut <marius.predut at intel.com>
Cc: "10.6 11.0" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit c0b3b2f7603eab210acdb2e654e5411fe912ca34)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8be6b32d6558109fce4b63c90b434dd834819907
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Mon Sep 14 11:50:28 2015 -0700
t_dd_dmatmp: Use '& 3' instead of '% 4' everywhere
No piglit regressions on i915 (G33) or radeon (Radeon 7500).
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Brian Paul <brianp at vmware.com>
Cc: "10.6 11.0" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 0d475ee2b989ac1697720ca391913e9158156bdc)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0e0d008b2b836441cd848365afecbcc32c86c235
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Mon Sep 14 11:46:50 2015 -0700
t_dd_dmatmp: Clean up improper code formatting from previous patch
No piglit regressions on i915 (G33) or radeon (Radeon 7500).
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Brian Paul <brianp at vmware.com>
Cc: "10.6 11.0" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit fad8d54de7e7f908cb0d06f0b54af8440e689928)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=007aae740eb5fd0e5446e6e6d52d29fb8d5c32e5
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Mon Sep 14 11:37:12 2015 -0700
t_dd_dmatmp: Make "count" actually be the count
The value passed in count previously was "vertex after the last vertex
to be processed." Calling that "count" was misleading and kind of mean.
Looking at the code, many functions immediately do "count-start" to get
back the true count. That's just silly.
If it is better for the loops to be 'for (j = start; j < (start +
count); j++)', GCC will do that transformation.
NOTE: There is some strange formatting left by this patch. That was
done to make it more obvious that the before and after code is
equivalent. These will be fixed in the next patch.
No piglit regressions on i915 (G33) or radeon (Radeon 7500).
v2: Fix a remaining (count-start) in render_quad_strip_verts.
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Brian Paul <brianp at vmware.com> [v1]
Cc: "10.6 11.0" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit d7bf7969b90f66ee614f2d2225f3a821d5396a89)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=575f5a94c3b45e4501b6c3a2e1ec731415b1779a
Author: Iago Toral Quiroga <itoral at igalia.com>
Date: Tue Feb 24 19:02:56 2015 +0100
mesa: Fix GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE for default framebuffer.
From section 9.2. Binding and Managing Framebuffer Objects:
"Upon successful return from Get*FramebufferAttachmentParameteriv, if
pname is FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE, then params will contain
one of NONE, FRAMEBUFFER_DEFAULT, TEXTURE, or RENDERBUFFER, identifying
the type of object which contains the attached image."
And then it clarifies further:
"If the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE is NONE, then
either no framebuffer is bound to target; or the default framebuffer is
bound, attachment is DEPTH or STENCIL, and the number of depth or stencil
bits, respectively, is zero"
Currently, if the default framebuffer is bound, we always return
GL_FRAMEBUFFER_DEFAULT for FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE, but
according to the spec, when GL_DEPTH or GL_STENCIL attachments are
the ones being queried, we should return GL_NONE if they don't exist.
Fixes the following dEQP test:
dEQP-GLES3.functional.state_query.fbo.framebuffer_attachment_x_size_initial
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Cc: "10.6" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit cf439951b791827677e96d29e209b5fc08d07a2e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b1203ec9f3929993180591343264f6549207c8cc
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Mon Sep 7 15:08:13 2015 +0300
i965: fix textureGrad for cubemaps
Fixes bugs exposed by commit
2b1cdb0eddb73f62e4848d4b64840067f1f70865 in:
ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_frag
No regressions observed in deqp, CTS or Piglit.
v2: address review feedback from Iago Toral:
- move rho calculation to else branch
- optimize dx and dy calculation
- fix documentation inconsistensies
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Signed-off-by: Kevin Rogovin <kevin.rogovin at intel.com>
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91114
Cc: "10.6 11.0" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 7f8815bcb9af9b4b374ad7bd6e7cfa7529a6c980)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c29e3f1bcaa1a347bfc2eed4c07adbb2eb5fbb20
Author: Jeremy Huddleston <jeremyhu at freedesktop.org>
Date: Sat Aug 29 14:51:45 2015 -0700
configure.ac: Add support to enable read-only text segment on x86.
Cc: "10.6 11.0" <mesa-stable at lists.freedesktop.org>
Bugzilla: https://bugs.gentoo.org/240956
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
(cherry picked from commit 6dfc5e28f7d08094210d8cecd3ed4a5b393dafe9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c98217178b268905b9492eaa344ca68c20857042
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Sat Sep 19 16:19:26 2015 -0400
radeonsi: load fmask ptr relative to the resources array
res_ptr already contains the resource values. fmask_ptr needs to be
looked up relative to the start of the resource params.
Note that this only affects indirect loads of MS sampler arrays.
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Cc: "11.0" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 7d5162bdc0850c80f4b9427a2aac6b42c7dcceaa)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=278739eb0169e25e82eae322e337e6c9a7390083
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Tue Sep 15 09:17:20 2015 +0300
mesa: fix errors when reading depth with glReadPixels
OpenGL ES 3.0 spec 3.7.2 "Transfer of Pixel Rectangles" specifies
DEPTH_COMPONENT, UNSIGNED_INT as a valid couple, validation for
internal format is checked by is_float_depth().
Fix regression caused by 81d2fd91a90e5b2fd9fd74792a7a7c329f0e4d29 in:
ES3-CTS.gtf.GL3Tests.packed_pixels.packed_pixels
Test uses GL_DEPTH_COMPONENT, UNSIGNED_INT only when GL_NV_read_depth
extension is present.
v2: change check in _mesa_error_check_format_and_type to be explicit
for ES 2.0+, desktop OpenGL does not allow this behaviour + uses
this function for both glReadPixels and glDrawPixels validation.
(No Piglit regressions seen with v2.)
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>
Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com> [v1]
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92009
Cc: "10.6 11.0" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit afa1efdc8522d987e3af7c7a6272021caa33eb82)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ae6dcfee56de0f0bf96bac2ddcf5c578a05c7f7e
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Wed Sep 16 22:17:18 2015 -0400
nv50,nvc0: flush texture cache in presence of coherent bufs
This fixes the newly-added arb_texture_buffer_object-bufferstorage
piglit test.
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Cc: "11.0" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit e844e1007d3baac09ff2cc78879d6974be18ecaf)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9fcf28bb147ef6229c6690a70c62d36bcd93bf8b
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Tue Sep 15 01:32:40 2015 -0400
nv50,nvc0: detect underlying resource changes and update tic
When updating texture buffers, we might end up replacing the whole
buffer. Check that the tic address matches the resource address, and if
not, update the tic and reupload it.
This fixes:
arb_direct_state_access-texture-buffer
arb_texture_buffer_object-data-sync
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Cc: "11.0" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 323c91250682ac931941047f282a613c74b1ba26)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5fe09ffe6a5ae4fc0629e44b21ae144e347bcf04
Author: Ulrich Weigand <uweigand at de.ibm.com>
Date: Tue Sep 15 15:23:26 2015 +0200
mesa: Fix texture compression on big-endian systems
Various pieces of code to create compressed textures will first
generate an uncompressed RGBA texture into a temporary buffer,
and then read from that buffer while creating the final compressed
texture in the requested format.
The code reading from the temporary buffer assumes the buffer is
formatted as an array of bytes in RGBA order. However, the buffer
is filled using a _mesa_texstore call with MESA_FORMAT_R8G8B8A8_UNORM
format -- this is defined as an array of *integers* holding the
RGBA values in packed format (least-significant to most-significant).
This means incorrect bytes are accessed on big-endian systems.
This patch fixes this by using the MESA_FORMAT_A8B8G8R8_UNORM format
instead on big-endian systems when filling the buffer. This fixes
about 100 piglit test case failures on s390x for me.
Signed-off-by: Ulrich Weigand <ulrich.weigand at de.ibm.com>
Tested-by: Oded Gabbay <oded.gabbay at gmail.com>
Cc: "10.6" "11.0" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Dave Airlie <airlied at gmail.com>
(cherry picked from commit bd016a2601a741799bc76734deae0cb9ebcb2b8f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=395cd23690345ce4a5c4b97ba6497009a984240e
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Mon Sep 14 01:59:01 2015 -0400
freedreno/a3xx: fix blending of L8 format
Even though luminance formats don't have alpha, we still want the alpha
output to go to the blender. This fixes the luminance blending tests.
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Cc: "11.0" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 545a3cbb011e0e7722c2accb330c0994aea5cc38)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d04024cffa9dcce467cbaf89809f9ec1512f9703
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Tue Sep 15 19:39:25 2015 -0400
nv50, nvc0: fix max texture buffer size to 128M elements
This is what the hardware supports, there never was any sort of 64K
limit.
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Cc: "10.6 11.0" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 7a275fcda8ffa3d69b7be6f356469f4af272a6ad)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=370c2b344bd6da3d7840daf45cde09da0cd66adc
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Tue Sep 15 19:32:10 2015 -0400
st/mesa: avoid integer overflows with buffers >= 512MB
This fixes failures with the newly-submitted max-size texture buffer
piglit test for GPUs exposing >= 128M max texels.
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Cc: "10.6 11.0" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Glenn Kennard <glenn.kennard at gmail.com>
(cherry picked from commit eb081681df248750727a8a76436760d617b4a6a9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bcb3bfd5101f2f930fd91a7c7bbd050172d16572
Author: Ray Strode <rstrode at redhat.com>
Date: Fri Aug 28 14:50:21 2015 -0400
gbm: convert gbm bo format to fourcc format on dma-buf import
At the moment if a gbm buffer is imported and the gbm buffer
has an old-style GBM_BO_FORMAT format, the import will crash,
since it's passed directly to DRI functions that expect
a fourcc format (as provided by the newer GBM_FORMAT
definitions)
This commit addresses the problem in two ways:
1) it prevents invalid formats from leading to a crash by
returning EINVAL if the image couldn't be created
2) it translates GBM_BO_FORMAT formats into the comparable
GBM_FORMAT formats.
Reference: https://bugzilla.gnome.org/show_bug.cgi?id=753531
CC: "10.6 11.0" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
Reviewed-by: Kristian Høgsberg <krh at bitplanet.net>
(cherry picked from commit 4bf151e66279da00655cec02aadb52c9c6583213)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ebfa2ea34fd213b1395db7f9741d7cc181b2c415
Author: Anuj Phogat <anuj.phogat at gmail.com>
Date: Fri Jul 24 15:53:58 2015 -0700
meta: Abort meta pbo path if TexSubImage need signed unsigned conversion
See similar fix for Readpixels in mesa commit 0d20790. Jason suggested
we need that for TexSubImage as well.
Cc: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>
(cherry picked from commit 64e25167ed284619dacab42fdada0bb0fea71321)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3736ef3a171d673fbce6506000ab8aa8c1fb7f39
Author: Antia Puentes <apuentes at igalia.com>
Date: Mon Sep 14 09:50:59 2015 +0200
i965/vec4_nir: Load constants as integers
Loads constants using integer as their register type, like it is
done in FS backend.
No shader-db changes in HSW.
Cc: "10.6 11.0" <mesa-stable at lists.freedesktop.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91716
Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>
(cherry picked from commit b8d2263c83d29f4626ac0fe0316978aa6262aefb)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d9e4a3ae6abb6b331f149175b65c0ffb44794a55
Author: Antia Puentes <apuentes at igalia.com>
Date: Wed Aug 5 15:57:33 2015 +0200
i965/vec4: Fix saturation errors when coalescing registers
If the register types do not match and the instruction
that contains the final destination is saturated, register
coalescing generated non-equivalent code.
This did not happen when using IR because types usually
matched, but it is visible in nir-vec4.
For example,
mov vgrf7:D vgrf2:D
mov.sat m4:F vgrf7:F
is coalesced to:
mov.sat m4:D vgrf2:D
The patch prevents coalescing in such scenario, unless the
instruction we want to coalesce into is a MOV (without type
conversion implied). In that case, the patch sets the register
types to the type of the final destination.
Shader-db results in HSW (only vec4 instructions shown):
total instructions in shared programs: 1754415 -> 1754416 (0.00%)
instructions in affected programs: 74 -> 75 (1.35%)
helped: 0
HURT: 1
GAINED: 0
LOST: 0
Only one extra instruction in one of the shaders, that comes from
eliminating a saturation error by preventing register coalesce.
Cc: "10.6 11.0" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>
(cherry picked from commit 79f1a7ae28c37f77e08e550cd077959a2a1f8341)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1afea31ad819884e1dc86f383faaff227b1b3d30
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Thu Sep 10 16:19:42 2015 -0700
i965/vec4: Don't reswizzle hardware registers
Cc: "11.0 10.6" <mesa-stable at lists.freedesktop.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91719
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit 1037e0a84f61f4b1815093bcfd548d4b58ca106f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d9b54a01bee82796249a59127af02d00ce6aa032
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Wed Sep 9 13:18:29 2015 -0700
nir: Fix a bunch of ralloc parenting errors
As of a10d4937, we would really like things associated with an instruction
to be allocated out of that instruction and not out of the shader. In
particular, you should be passing the instruction that will ultimately be
holding the source into nir_src_copy rather than an arbitrary memory
context.
We also change the prototypes of nir_dest_copy and nir_alu_src/dest_copy to
explicitly take an instruction so we catch this earlier in the future.
Cc: "11.0" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Thomas Helland <thomashelland90 at gmail.com>
(cherry picked from commit 8c8fc5f8336c8c79e5890265ae6c03271aa94075)
More information about the mesa-commit
mailing list