[Mesa-dev] [Mesa3d-dev] [PATCH] demos: import GLSL raytracing demos
kristof.ralovich at gmail.com
Sun Apr 18 15:35:20 PDT 2010
On Sun, Apr 18, 2010 at 18:32, "RALOVICH, Kristóf"
<kristof.ralovich at gmail.com> wrote:
> On Wed, Apr 14, 2010 at 18:59, "RALOVICH, Kristóf"
> <kristof.ralovich at gmail.com> wrote:
>> On Wed, Apr 14, 2010 at 17:49, Eric Anholt <eric at anholt.net> wrote:
>>> On Sun, 28 Mar 2010 17:52:16 -0400, RALOVICH, Kristóf <kristof.ralovich at gmail.com> wrote:
>>>> please see the attached patch for piglit. The patch includes 2 new
>>>> tests based on the demos I provided for mesa.
>>>> Let me know if I can further help!
>>> The main thing I'm concerned about is that you seem to be looking for
>>> pixel-precise results. Do you expect that from this code? Generally in
>>> piglit we try to construct some environment that gets a few consistent
>>> results and probe a few representative pixels out of it.
>> I'll update the patch based on Brian's conclusion to address this.
>>> Beyond that, since you didn't use git send-email, the patch came out
>>> mangled and I couldn't apply it to try it out.
>> The patch is actually an attachment to the email. Try saving it as
>> that, not copy-pasting from the email's text.
Here is an updated patch for piglit. I did not change
piglit_probe_pixel_rgb(), but rather introduced a threshold on the
percentage of the pixels that might exceed the 0.01 difference allowed
by piglit_probe_pixel_rgb(). I also fixed the whitespace mismatches in
the diff. Please apply!
If I can in any way help resolving the original (, ) bug reports
let me know!
1 - https://bugs.freedesktop.org/show_bug.cgi?id=26691
2 - https://bugs.freedesktop.org/show_bug.cgi?id=27060
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 569601 bytes
Desc: not available
More information about the mesa-dev