[Mesa-dev] [PATCH] Export TLS support in gl.pc

[Eric Anholt]

On Sun, 05 Dec 2010 23:34:56 -0700, tom fogal <tfogal at sci.utah.edu> wrote:
> Eric Anholt <eric at anholt.net> writes:
> > On Sun, 05 Dec 2010 18:04:54 -0700, tom fogal <tfogal at sci.utah.edu> wrote:
> > > More background:
> > >
> > >   http://www.mail-archive.com/mesa3d-dev@lists.sourceforge.net/msg12473.html
> > >   http://lists.x.org/archives/xorg-devel/2009-November/003411.html
> > >
> > > This is just the export, we don't autodetect it yet.
> > 
> > What is this patch for?  According to the second mail quoted, a TLS
> > loader works for both TLS and non-TLS drivers -- that is to say,
> > the X Server's loader should always default to having TLS support,
> 
> It's vaguely alluded to in this mail, too, which I probably should have
> linked:
> 
>   http://lists.x.org/archives/xorg-devel/2009-November/003361.html
> 
> but also Dan mentions in the first link that if we start TLS-ing all of
> our drivers arbitrarily, it's going to break w/ X because X doesn't do
> the autodetection currently.  Now that you make me re-read, this seems
> to be at odds with Ian's comments about a TLS-server supporting both
> TLS and non-TLS drivers.  Am I missing something?

This patch *really* needed a complete commit message so you could
explain what you were doing.  Something like:

"Export from gl.pc whether the drivers are built with TLS enabled.

The X Server doesn't enable the TLS loader by default because of some
unspecified interaction with selinux, which may or may not be enabled.
But if the Mesa drivers are built for TLS and the server isn't, it will
fail to load the drivers due to unresolved symbols.  So, expose the TLS
build information so the server can potentially detect and build with
TLS when it must at the expense of selinux."

But this is still a lame way to go about it.  Get the server fixed for
whatever fixable selinux problem ajax was talking about, and enable TLS
by default on linux, period.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20101207/8aaa199b/attachment.pgp>