[Mesa-dev] [PATCH] glsl: fix lowering conditional returns in subroutines

Kenneth Graunke kenneth at whitecape.org
Thu Dec 9 11:32:07 PST 2010


On Wednesday, December 01, 2010 05:52:22 am Fabian Bieler wrote:
> Hello!
> 
> My last mail was misleading. The described behaviour (continue out of loop
> etc.) occurs with mesa's current glsl compiler. The attached patch tries to
> fix that.
> 
> I appologize for the faulty description and hope it was the cause for the
> lack of feedback to my last mail.
> 
> I also attached two piglit tests to demonstrate the bug.
> 
> Fabian

Sorry for the delay - lower_jumps is pretty confusing code, and I'd hoped to 
understand it better before pushing the patch...but clearly it fixes your two 
test cases and doesn't seem to regress anything else, so...in it goes!

I've pushed the patch and added the two tests to piglit.  Thanks!


More information about the mesa-dev mailing list