[Mesa-dev] [PATCH] r600: Flip point sprite coordinates when rendering to an FBO.

Henri Verbeet hverbeet at gmail.com
Mon Jul 19 14:27:58 PDT 2010


On 19 July 2010 23:13, Matt Turner <mattst88 at gmail.com> wrote:
> I can't speak to the meaning of this change, but the use of ^ and !!
> is just an abuse of the language.
>
> ^ is binary XOR. Logical XOR is !=.
>
> Let's write this like
>    if ((ctx->Point.SpriteOrigin == GL_LOWER_LEFT) !=
> (ctx->DrawBuffer->Name != NULL))
>
Well, Name isn't a pointer. I can easily make this change if that's
really the preferred form, but I'm not sure why you'd consider ^ or !!
abuse, it looks more obvious to me.


More information about the mesa-dev mailing list