[Mesa-dev] [PATCH] vbo: Avoid unnecessary copy to/from current in vertex format upgrade.
keithw at vmware.com
Tue Nov 2 11:36:53 PDT 2010
On Tue, 2010-11-02 at 11:21 -0700, Francisco Jerez wrote:
> Keith Whitwell <keithw at vmware.com> writes:
> > Francisco,
> > This looks good - my only comment is that there seem to be two distinct
> > changes in this patch -- the modification to VBO behaviour when adding a
> > new attribute being one, but the changes to vbo_exec_draw.c seem to be
> > an unrelated cleanup. Is that correct?
> > Ordinarily I wouldn't bother pointing it out, but VBO is fairly complex
> > code & being able to isolate any regression to the smallest change
> > possible would be preferable -- would it be possible to split the patch
> > into two pieces & commit separately?
> Yes, I can split it in two pieces if you want, but that hunk isn't an
> unrelated cleanup, the bulk of this patch deals with fixing several
> places that assume that vertex attributes are stored in VBO_ATTRIB
> order, vbo_exec_bind_arrays() was one of them.
OK - if they're bound together then don't worry about splitting - it
wasn't easy to tell by looking at the patch. The change looks good to
More information about the mesa-dev