[Mesa-dev] [PATCH 07/13] i915g: drop alignment, type parameters for iws->buffer_create
wallbraker at gmail.com
Sat Nov 20 11:54:47 PST 2010
On Fri, Nov 19, 2010 at 11:38 PM, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> type was only used to name the buffer. If needed, better let the
> caller specify a meaningful name.
> alignment is also rather unecessary. The kernel gem ignores it totally,
> and we can't run on the old userspace fake bo manager due to lack of
I actually prefer it if you kept the type argument. As it allows you
to know what the intended usage of the buffer by just looking at the
struct data, even for the sw winsys, I don't care to much about
expanding that type into different names for libdrm_bo but they are
nice, tho the name_string is totally redundant for the sw winsys.
More information about the mesa-dev