[Mesa-dev] [RFC] discard optimization and lowering passes

Kenneth Graunke kenneth at whitecape.org
Thu Nov 25 09:49:21 PST 2010


On Thursday 25 November 2010 06:55:54 you wrote:
> I am ok with either solution as long as it fixes *Bug
> 31827*<https://bugs.freedesktop.org/show_bug.cgi?id=31827>
> .
> 
> I have tested my patch and it works. There was a bug in lower_jumps that
> made discard statements with a condition be treated as without it, causing
> the removal of all instructions after discard. This code from my patch
> fixes it:

Good call - that's definitely broken.  I suppose we never hit it before because 
we never generated conditional discards.

I'm tempted to simply remove discard from lower_jumps - the other two passes 
should handle it.


More information about the mesa-dev mailing list