[Mesa-dev] [RFC] discard optimization and lowering passes

Marek Olšák maraeo at gmail.com
Mon Nov 29 08:57:02 PST 2010


Please could we get this feature committed to master? I'd like to close Bug
31827.

Thank you.

Marek

On Thu, Nov 25, 2010 at 6:49 PM, Kenneth Graunke <kenneth at whitecape.org>wrote:

> On Thursday 25 November 2010 06:55:54 you wrote:
> > I am ok with either solution as long as it fixes *Bug
> > 31827*<https://bugs.freedesktop.org/show_bug.cgi?id=31827>
> > .
> >
> > I have tested my patch and it works. There was a bug in lower_jumps that
> > made discard statements with a condition be treated as without it,
> causing
> > the removal of all instructions after discard. This code from my patch
> > fixes it:
>
> Good call - that's definitely broken.  I suppose we never hit it before
> because
> we never generated conditional discards.
>
> I'm tempted to simply remove discard from lower_jumps - the other two
> passes
> should handle it.
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20101129/824fb79f/attachment.htm>


More information about the mesa-dev mailing list