[Mesa-dev] RFC: Whimsical renames and code motion
krh at bitplanet.net
Tue Oct 12 10:50:58 PDT 2010
2010/10/12 Ian Romanick <idr at freedesktop.org>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> Kristian Høgsberg wrote:
>> I wrote this patch series a while ago, but now that 7.9 is out I
>> thought I'd float it on the list to see what people think. The first
>> couple of patches kill off glcore.h, which is no longer used for any
>> external interfaces, and pull the struct into mtypes.h. The next
>> couple of patches massage it a bit to drop fields we don't use and
>> rename it and it's many typedefs to just struct gl_config. The patch
>> series finishes with two patches to drop the GLframebuffer and
>> GLcontext typedefs and just use struct gl_framebuffer and struct
>> gl_context instead. The last patch is 2MB, so I'll just point you to
> Doesn't the GLX code in the xserver use some of the same config structures?
Not glx/, I copied the struct into the glx module. It's still used by
dmx, Xephyr, xquarts and xwin32, but glproto installs a glcore.h too,
so they can pick it up from there. Ideally these users would use a
copy included in the Xserver, since it is just an imlpementation
detail, but that's a patch for another day.
> I'm very much in favor of less typedefs. I'd much rather just use
> 'struct gl_context', etc.
Yeah, me too.
More information about the mesa-dev