[Mesa-dev] [PATCH 1/2] intel: Fix ROUND_DOWN_TO macro

Ian Romanick idr at freedesktop.org
Mon Apr 11 11:11:33 PDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/11/2011 11:06 AM, Kenneth Graunke wrote:
> Acked-by: Kenneth Graunke <kenneth at whitecape.org>
> 
> I don't really care whether it's called ALIGN_FLOOR or ROUND_DOWN_TO;
> either is fine by me.  I might add a comment saying that these only work
> if the second parameter is a power of two.

Which somewhat argues for ALIGN_FLOOR.  You don't usually think of
aligning to anything other than a power of two.  In any case, adding the
comment is a good idea.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk2jRFUACgkQX1gOwKyEAw9rdACgi9vWQMszsWTDIhnmYJakorT3
+L8AnRQiBCQRttI3CfW4Bga6NFlPDYHL
=ISq9
-----END PGP SIGNATURE-----


More information about the mesa-dev mailing list