[Mesa-dev] [PATCH] r200: enable EXT_gpu_program_parameters

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/16/2011 03:01 AM, Nicolas Kaiser wrote:
> Signed-off-by: Nicolas Kaiser <nikai at nikai.net>
> ---
> According to Marek Olšák, this extension is quite popular in
> the GL community.[1]

Yeah, and it's a very trivial extension to support, too.  I actually
think that this extension should always be enabled if the driver enables
GL_ARB_vertex_program or GL_ARB_fragment_program.  Since I don't think
there are any drivers that enable ARB_fp and not ARB_vp, we could
probably make EXT_gpp share the same bit with ARB_vp.

> Tests look good:
> ./src/tests/prog_parameter 
> GL_RENDERER = Mesa DRI R200 (R200 514D)  TCL DRI2
> GL_VERSION = 1.3 Mesa 7.11-devel (git-4ee40c3)
> 
> GL_EXT_gpu_program_parameters available, testing that path.
> Testing glProgramEnvParameter4fvARB (count = 256)...
> Testing glProgramEnvParameters4fvEXT (count = 256)...
> Testing glProgramLocalParameter4fvARB (count = 1024)...
> Testing glProgramLocalParameters4fvEXT (count = 1024)...
> PASS!
> 
> Best regards,
> Nicolas Kaiser
> 
> [1] http://www.mail-archive.com/mesa3d-dev@lists.sourceforge.net/msg12980.html
> 
>  src/mesa/drivers/dri/r200/r200_context.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/r200/r200_context.c b/src/mesa/drivers/dri/r200/r200_context.c
> index 4773263..d19370e 100644
> --- a/src/mesa/drivers/dri/r200/r200_context.c
> +++ b/src/mesa/drivers/dri/r200/r200_context.c
> @@ -69,6 +69,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
>  #define need_GL_EXT_secondary_color
>  #define need_GL_EXT_blend_equation_separate
>  #define need_GL_EXT_blend_func_separate
> +#define need_GL_EXT_gpu_program_parameters
>  #define need_GL_NV_vertex_program
>  #define need_GL_ARB_point_parameters
>  #define need_GL_EXT_framebuffer_object
> @@ -123,6 +124,7 @@ static const struct dri_extension card_extensions[] =
>      { "GL_EXT_blend_minmax",               GL_EXT_blend_minmax_functions },
>      { "GL_EXT_blend_subtract",             NULL },
>      { "GL_EXT_fog_coord",                  GL_EXT_fog_coord_functions },
> +    { "GL_EXT_gpu_program_parameters",     GL_EXT_gpu_program_parameters_functions},
>      { "GL_EXT_packed_depth_stencil",	   NULL},
>      { "GL_EXT_secondary_color",            GL_EXT_secondary_color_functions },
>      { "GL_EXT_stencil_wrap",               NULL },

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk2so6kACgkQX1gOwKyEAw+XvACfTgntrvfrx08p5ckl1k9ERQol
sDoAnRYrZuho4E1gOwtnWpXV6JSf5qkq
=8hxS
-----END PGP SIGNATURE-----