[Mesa-dev] [PATCH 5/5] glsl: Clarify ir_function::matching_sigature()

[Chad Versace]

On 08/01/2011 08:05 AM, Chris Bandy wrote:
> On 07/29/2011 08:59 PM, Chad Versace wrote:
>> The function used a variable named 'score', which was an outright lie.
>> A signature matches or it doesn't; there is no fuzzy scoring.
>>
>> Change the return type of parameter_lists_match() to an enum, and
>> let ir_function::matching_sigature() switch on that enum.
>>
>> CC: Ian Romanick <ian.d.romanick at intel.com>
>> CC: Kenneth Graunke <kenneth at whitecape.org>
>> Signed-off-by: Chad Versace <chad at chad-versace.us>
>> ---
>>  src/glsl/ir_function.cpp |   53 ++++++++++++++++++++++++++++-----------------
>>  1 files changed, 33 insertions(+), 20 deletions(-)
>>
>> diff --git a/src/glsl/ir_function.cpp b/src/glsl/ir_function.cpp
>> index dd63e30..6cfc32c 100644
>> --- a/src/glsl/ir_function.cpp
>> +++ b/src/glsl/ir_function.cpp
>> @@ -24,17 +24,28 @@
>>  #include "glsl_types.h"
>>  #include "ir.h"
>>  
>> +typedef enum {
>> +   PARAMETER_LIST_NO_MATCH,
>> +   PARAMETER_LIST_EXACT_MATCH,
>> +   PARAMETER_LIST_INEXACT_MATCH, /*< Match requires implicit conversion. */
>> +} parameter_list_match_t;
>> +
>>  /**
>>   * \brief Check if two parameter lists match.
>>   *
>>   * \param list_a Parameters of the function definition.
>>   * \param list_b Actual parameters passed to the function.
>> - * \return If an exact match, return 0.
>> - *         If an inexact match requiring implicit conversion, return 1.
>> - *         If not a match, return -1.
>>   * \see matching_signature()
>>   */
> 
> Looks like the above comment block is now duplicated here.

Thanks Chris.

I just pushed the fix.

commit 5541920e0ac4ea8383c7f896daba24a304aafec6
Author: Chad Versace <chad at chad-versace.us>
Date:   Mon Aug 1 09:36:08 2011 -0700

    glsl: Remove duplicate comment

    Remove duplicate doxgen comment for
    ir_function.cpp:parameter_lists_match().

    Signed-off-by: Chad Versace <chad at chad-versace.us>

-- 
Chad Versace
chad at chad-versace.us