[Mesa-dev] Mesa (master): egl/gbm: Fix EGL_DEFAULT_DISPLAY

Ian Romanick idr at freedesktop.org
Fri Aug 5 13:31:44 PDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/04/2011 03:32 PM, Chad Versace wrote:
> This commit *really* needs a more descriptive commit message.
>   - What were the symptoms of the broken EGL_DEFAULT_DISPLAY?
>   - What error in the code caused the problem?
>   - What the hell did you do to fix it? This is not evident due to the length
>     of the commit.
> 
> For commits of this complexity, write descriptive messages for the sake of others.

I have to agree with Chad.  I'm not comfortable with the number of
patches happening in the egl subtree that don't have *ANY* Reviewed-by,
Acked-by, or Tested-by lines.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk48UzAACgkQX1gOwKyEAw/OCACdF3xMucS7urTarYlPOPnCny5j
DxUAn2Xvumzn5Eotyjak4DacYBegoZmV
=fkmv
-----END PGP SIGNATURE-----


More information about the mesa-dev mailing list