[Mesa-dev] [PATCH] glsl: When assigning to a whole array, mark the array as accessed.

Eric Anholt eric at anholt.net
Thu Aug 11 17:10:43 PDT 2011


On Fri,  5 Aug 2011 21:48:53 -0700, Eric Anholt <eric at anholt.net> wrote:
> The vs-varying-array-mat2-col-row-wr test writes a mat2[3] constant to
> a mat2[3] varying out array, and also statically accesses element 1 of
> it on the VS and FS sides.  At link time it would get trimmed down to
> just 2 elements, and then codegen of the VS would end up generating
> assignments to the unallocated last entry of the array.  On the new
> i965 VS backend, that happened to land on the vertex position.
> 
> Some issues remain in this test on softpipe, i965/old-vs and
> i965/new-vs on visual inspection, but i965 is passing because only one
> green pixel is probed, not the whole split green/red quad.
> ---
> 
> Note: This hasn't seen a full piglit run yet.

And, of course, because it hadn't seen a full piglit run, it's broken
(scoping1.frag crashes).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110811/e107ae6a/attachment.pgp>


More information about the mesa-dev mailing list