[Mesa-dev] [PATCH 1/1] Fix minor inconsistency for new method try_emit_mad_for_and_not()
idr at freedesktop.org
Mon Aug 22 09:53:07 PDT 2011
-----BEGIN PGP SIGNED MESSAGE-----
On 08/22/2011 03:10 AM, Kai Wasserbäch wrote:
> Commits ff2cfb8989cd and 5379a70d3fab introduced
> try_emit_mad_for_and_not for ir_to_mesa and glsl_to_tgsi respectively.
> In both cases the methods had a return type of "bool" instead of
In general we're trying to move away from GLboolean in places that
aren't part of the GL API (i.e., places where it's required). See this
mailing list thread:
It it was a mistake use GLboolean in the other try_emit_* functions.
When I added try_emit_mad_for_and_not, I followed the "new" guidelines.
I would support a patch that changes the return type of the other
try_emit_* functions and adds some test to docs/devinfo.html about the
use of bool vs. GLboolean.
> Signed-off-by: Kai Wasserbäch <kai at dev.carbon-project.org>
> src/mesa/program/ir_to_mesa.cpp | 4 ++--
> src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----
More information about the mesa-dev