[Mesa-dev] glGetUniform rework v2 and VS backend uniform array support

Kenneth Graunke kenneth at whitecape.org
Wed Aug 24 11:44:34 PDT 2011


On 08/23/2011 06:25 PM, Eric Anholt wrote:
> This finishes off the remaining piglit regressions in the new VS
> backend, so that now it overall fixes 2 tests
> (vs-temp-array-mat4-index-col-row-rd,
> vs-temp-array-mat4-index-row-rd).
>
> After Ken's note about type conversion for non-GL_FLOAT returntype, I
> noticed a one-character typo in the testcase that made the getuniform
> testcase rather useless.  Woo.  I also made the testcase cover
> rounding for float ->  int and assert that rounding is the correct
> behavior -- I'd be interested in what other implementations do, since
> the spec is unclear.

Other than my comments on patch 6, this series is now
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list