[Mesa-dev] [PATCH 02/13] util: Fix include style

Kai Wasserbäch kai at dev.carbon-project.org
Sat Aug 27 08:51:48 PDT 2011


As explained in the thread starting at [0], the internal include style
should be »#include "path/to/header.h"« for non-system includes.

[0]
<http://news.gmane.org/find-root.php?message_id=%3c4E5802BE.6020206%40vmware.com%3e>

Signed-off-by: Kai Wasserbäch <kai at dev.carbon-project.org>
---
 src/gallium/auxiliary/util/u_debug_describe.c |    8 ++++----
 src/gallium/auxiliary/util/u_debug_refcnt.c   |   16 ++++++++--------
 src/gallium/auxiliary/util/u_debug_refcnt.h   |    4 ++--
 src/gallium/auxiliary/util/u_video.h          |    8 ++++----
 4 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/src/gallium/auxiliary/util/u_debug_describe.c b/src/gallium/auxiliary/util/u_debug_describe.c
index 7ed8ee6..3574acc 100644
--- a/src/gallium/auxiliary/util/u_debug_describe.c
+++ b/src/gallium/auxiliary/util/u_debug_describe.c
@@ -24,10 +24,10 @@
  *
  **************************************************************************/
 
-#include <pipe/p_state.h>
-#include <util/u_format.h>
-#include <util/u_debug_describe.h>
-#include <util/u_string.h>
+#include "pipe/p_state.h"
+#include "util/u_format.h"
+#include "util/u_debug_describe.h"
+#include "util/u_string.h"
 
 void
 debug_describe_reference(char* buf, const struct pipe_reference*ptr)
diff --git a/src/gallium/auxiliary/util/u_debug_refcnt.c b/src/gallium/auxiliary/util/u_debug_refcnt.c
index 6f706a3..b3e3894 100644
--- a/src/gallium/auxiliary/util/u_debug_refcnt.c
+++ b/src/gallium/auxiliary/util/u_debug_refcnt.c
@@ -29,14 +29,14 @@
 /* see http://www.mozilla.org/performance/refcnt-balancer.html for what do with the output
  * on Linux, use tools/addr2line.sh to postprocess it before anything else
  **/
-#include <util/u_debug.h>
-#include <util/u_debug_refcnt.h>
-#include <util/u_debug_stack.h>
-#include <util/u_debug_symbol.h>
-#include <util/u_string.h>
-#include <util/u_hash_table.h>
-#include <os/os_thread.h>
-#include <os/os_stream.h>
+#include "util/u_debug.h"
+#include "util/u_debug_refcnt.h"
+#include "util/u_debug_stack.h"
+#include "util/u_debug_symbol.h"
+#include "util/u_string.h"
+#include "util/u_hash_table.h"
+#include "os/os_thread.h"
+#include "os/os_stream.h"
 
 int debug_refcnt_state;
 
diff --git a/src/gallium/auxiliary/util/u_debug_refcnt.h b/src/gallium/auxiliary/util/u_debug_refcnt.h
index bea2d1c..c02fba2 100644
--- a/src/gallium/auxiliary/util/u_debug_refcnt.h
+++ b/src/gallium/auxiliary/util/u_debug_refcnt.h
@@ -27,8 +27,8 @@
 #ifndef U_DEBUG_REFCNT_H_
 #define U_DEBUG_REFCNT_H_
 
-#include <pipe/p_config.h>
-#include <pipe/p_state.h>
+#include "pipe/p_config.h"
+#include "pipe/p_state.h"
 
 #ifdef __cplusplus
 extern "C" {
diff --git a/src/gallium/auxiliary/util/u_video.h b/src/gallium/auxiliary/util/u_video.h
index 6b67881..be3fac2 100644
--- a/src/gallium/auxiliary/util/u_video.h
+++ b/src/gallium/auxiliary/util/u_video.h
@@ -32,12 +32,12 @@
 extern "C" {
 #endif
 
-#include <pipe/p_defines.h>
-#include <pipe/p_video_enums.h>
+#include "pipe/p_defines.h"
+#include "pipe/p_video_enums.h"
 
 /* u_reduce_video_profile() needs these */
-#include <pipe/p_compiler.h>
-#include <util/u_debug.h>
+#include "pipe/p_compiler.h"
+#include "util/u_debug.h"
 
 static INLINE enum pipe_video_codec
 u_reduce_video_profile(enum pipe_video_profile profile)
-- 
1.7.5.4



More information about the mesa-dev mailing list