[Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

Andy Furniss andyqos at ukfsn.org
Mon Dec 19 04:50:15 PST 2011


Maarten Lankhorst wrote:
>
> Looks like I made the checking a bit too paranoid, causing it to not always decode last few macroblocks because of fear of reaching end of stream..
> Does this work? I removed a few paranoid asserts, and if performance is still bad, I'll alter the patch to swap between multiple decode buffers to fix it. That should bring performance back to old level.

This version does fix the macroblocks issue.

Perf is still poor.

The dvd assert is also still present. It doesn't happen with all dvds - 
and is not a regression caused by this patch.

When playing with -cache and skipping around I get a different assert - 
attached are backtraces from both types.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: vdpau-dvd-skip-bt
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111219/1fdee610/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: vdpau-dvd-start-bt
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111219/1fdee610/attachment.asc>


More information about the mesa-dev mailing list