[Mesa-dev] [PATCH 6/8] i965: get the jmp distance by instruction index

Eric Anholt eric at anholt.net
Thu Dec 22 09:55:55 PST 2011


On Thu, 22 Dec 2011 10:18:05 +0800, Yuanhan Liu <yuanhan.liu at linux.intel.com> wrote:
> On Wed, Dec 21, 2011 at 05:57:35AM -0800, Eric Anholt wrote:
> > On Wed, 21 Dec 2011 17:33:41 +0800, Yuanhan Liu <yuanhan.liu at linux.intel.com> wrote:
> > > If dynamic instruction store size is enabled, while after the brw_JMPI()
> > > and before the brw_land_fwd_jump() function, the eu instruction store
> > > base address(p->store) may change. Thus, the safe way to reference the
> > > jmp instruction is by index instead of by the instruction address.
> > 
> > Our other instructions return the instruction pointer, I don't think
> > jmpi should be special in that respect.
> 
> Right. Fixed and how about the following patch?

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111222/2ab5279a/attachment.pgp>


More information about the mesa-dev mailing list