[Mesa-dev] i965/gen7 transform feedback

[Paul Berry]

On 22 December 2011 16:54, Eric Anholt <eric at anholt.net> wrote:

> Here's today's patch series for gen7 transform feedback.  It runs on
> top of a kernel patch at people.freedesktop.org:~anholt/linux on the
> gen7-reset-sol branch.  I expected it to be easy, but not this easy.
>

This is fantastic, Eric.  I'm really pleased how quickly this is coming
together.

Other than a few minor comments that I've already sent out, the series is:
Reviewed-by: Paul Berry <stereotype441 at gmail.com>


>
> Remaining test failures:
>
>        tessellation polygon flat_last        warn
>        tessellation quad_strip flat_last     warn
>        tessellation quads flat_last          warn
>        tessellation triangle_fan flat_first  fail
>

I'm sorry to hear that triangle_fan flat_first fails--both AMD and nVidia
pass that test, so it's a bit embarrassing for Intel to fail it.  But it's
an obscure case (who flatshades trifans anyhow, especially when using
transform feedback?) and I can't see any way of fixing it on Gen7 without
firing up the GS, which seems like *way* overkill.  I'm far less bothered
by the 3 warnings, because nVidia gets those exact same warnings too.

So IMHO, it's ok to leave these 4 tests failing.

Incidentally, Gen6 gets the exact same 4 failures, plus 4 additional
failures for "tessellation triangle_strip".  I'll try to fix "tessellation
triangle_strip" tomorrow.


>
> Also, it looks like none of the current piglit tests test transform
> feedback across batchbuffers.  I don't expect major problems there,
> given that we have a userland count of verts emitted.
>

I have 3 more work days left in the year, so I'll try to implement those
tests before you need them.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111222/ab27b252/attachment-0001.htm>