[Mesa-dev] [PATCH 1/3] i965/vs: Fix incorrect subscript when resetting copy propagation records.
mattst88 at gmail.com
Fri Dec 23 21:44:21 PST 2011
On Fri, Dec 23, 2011 at 11:57 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> In this code, 'i' loops over the number of virtual GRFs, while 'j' loops
> over the number of vector components (0 <= j <= 3).
> It can't possibly be correct to see if bit 'i' is set in the destination
> writemask, as it will have values much larger than 3. Clearly this is
> supposed to be 'j'.
> Found by inspection.
> Cc: Eric Anholt <eric at anholt.net>
> Cc: Matt Turner <mattst88 at gmail.com>
> Cc: Christopher James Halse Rogers <chalserogers at gmail.com>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> .../drivers/dri/i965/brw_vec4_copy_propagation.cpp | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> Matt and Christopher,
> Could you test Counter Strike and Civ V with this patch series?
> I think it should solve your regressions with the new VS backend.
The dxlevel 90 trace I gave you now plays back fine. The menu renders
properly, and many little graphical glitches seen during the video
stress test are also gone.
In the mean time, I've apparently hosed my wine configuration, so I'm
not having luck duplicating the results, but alas.
Thanks a lot for checking this out. I really appreciate it.
The series is Tested-by: Matt Turner <mattst88 at gmail.com>
More information about the mesa-dev