[Mesa-dev] [PATCH] Export TLS support in gl.pc.

[Dan Nicholson]

On Mon, Jan 10, 2011 at 3:08 PM, tom fogal <tfogal at sci.utah.edu> wrote:
> Dan Nicholson <dbn.lists at gmail.com> writes:
>> On Sun, Jan 9, 2011 at 2:32 PM, tom fogal <tfogal at sci.utah.edu> wrote:
>> > Ping!
>> >
>> > No NAKs in ~5 days and one explicit request (on xorg-devel):
>> >
>> > =C2=A0http://permalink.gmane.org/gmane.comp.freedesktop.xorg.devel/17570
>> >
>> > Okay for master, and (after settling) 7.10?
>>
>> Sorry, I was thinking of replying 5 days ago but then got distracted
>> and forgot. :)
>
> no worries, it happens!
>
>> The only thing I think is missing is the default fallback setting in
>> configs/default. If you do the non-autoconf build, you'd end up with
>> an empty field there.
>
> Ooops, yep, good catch.  I had already pushed, but I just now pushed a
> one-liner to fix this (0e3ff159f950f7481af53506a8331476bc54c00f).  It
> looks to me like it defaults to off in those builds, so I used a `no'
> default, but we rarely use those builds so please correct me if I've
> got it wrong.
>
>> It might also be nice if we sanity checked the value we're going to
>> put in gl.pc. Not a big deal, though.
>
> You mean something like:
>
>  if test "${var}" != "no" -a "${var}" != "yes" ; then
>    echo "some error"
>    exit 1
>  fi
>
> ? Where, then?  That seems a little ucky to put into the makefiles, to
> me.  The alternative seems to be configure.ac, which wouldn't catch
> non-ac builds, of course.  Maybe you thought that was acceptable?

Yeah, in configure.ac, but then again it would only happen if you did
something like --enable-glx-tls=yeah. It's probably not worth caring.

--
Dan