[Mesa-dev] [PATCH 1/2] amendment: Change dependency on some extension strings

[Chad Versace]

On 01/11/2011 11:20 AM, Ian Romanick wrote:
> On 01/09/2011 11:53 PM, Chad Versace wrote:
>> +   { "GL_OES_framebuffer_object",                  o(ARB_framebuffer_object),                       ES1       },
> 
> I think this and the other OES framebuffer object related extensions
> should depend on EXT_framebuffer_object.
> 
>> +   { "GL_OES_point_sprite",                        o(dummy_true),                                   ES1       },
> 
> This should depend on GL_ARB_point_sprite.

Done. I've amended patch 1/2 with the attached patch.

>> +   { "GL_OES_standard_derivatives",                o(ARB_fragment_shader),                                ES2 },
> 
> This should be a stand-alone extension.  We have some hardware (i.e.,
> r300 and i915) that advertises support for ARB_fragment_shader but
> cannot do the partial derivatives.

struct gl_extensions (in src/mesa/main/mtypes.h) does not a member for
OES_standard_derivatives. Is the proper action here to add that member,
and then let drivers selectively enable it? Or to add that member, and
always enable it by default?

-- 
Chad Versace
chad.versace at intel.com
chad at chad-versace.us
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: a.patch
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110111/91704b28/attachment.txt>