[Mesa-dev] [Bug 38842] Various valid GLX attributes are rejected by MESA glxChooseFBConfig

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38842

--- Comment #2 from Jonathan Kirkham <jonathan.kirkham at arm.com> 2011-07-07 09:21:33 PDT ---
This solves the immediate problem that the attributes are rejected, however, I
do not believe this change is solving the real problem.


In this patch if the attribute GLX_MAX_PBUFFER_WIDTH is passed in, the value of
 desiredVisualID is set to be the value of this attribute which looks incorrect
to me. The individual case statements for the attributes need to do something,
not drop through to the GLX_VISUAL_ID case where desiredVisualID is set.

Is it possible that the other cases should be:

         case GLX_MAX_PBUFFER_WIDTH:
           parselist +=2; //skip

         case GLX_MAX_PBUFFER_HEIGHT:
         case GLX_MAX_PBUFFER_PIXELS:
         case GLX_VISUAL_ID:
            if (!fbConfig)
               return NULL; /* invalid config option */
            parselist++;
            desiredVisualID = *parselist++;
            break;

The result of testing this patch is that no configs are returned by
glxGetFBConfig, presumably because desiredVisualID is set incorrectly.



Thanks for taking the time to look into this problem.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.