[Mesa-dev] Mesa (master): mesa: fix assertion failure in _mesa_test_formats

Jose Fonseca jfonseca at vmware.com
Mon Jul 11 06:14:34 PDT 2011


Marek,

Please add the comment /* Z32_FLOAT_X24S8 has DataType of GL_NONE */ in from of DataType == GL_NONE, otherwise I think nobody will guess what that's about.

Jose

----- Original Message -----
> Module: Mesa
> Branch: master
> Commit: e134eaa2c5619b47e944e33d053ee23c61da7aa9
> URL:
>    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e134eaa2c5619b47e944e33d053ee23c61da7aa9
> 
> Author: Marek Olšák <maraeo at gmail.com>
> Date:   Mon Jul 11 13:53:42 2011 +0200
> 
> mesa: fix assertion failure in _mesa_test_formats
> 
> Z32_FLOAT_X24S8 has DataType of GL_NONE.
> 
> ---
> 
>  src/mesa/main/formats.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/src/mesa/main/formats.c b/src/mesa/main/formats.c
> index f58b197..e01ea11 100644
> --- a/src/mesa/main/formats.c
> +++ b/src/mesa/main/formats.c
> @@ -1485,7 +1485,8 @@ _mesa_test_formats(void)
>               info->DataType == GL_SIGNED_NORMALIZED ||
>               info->DataType == GL_UNSIGNED_INT ||
>               info->DataType == GL_INT ||
> -             info->DataType == GL_FLOAT);
> +             info->DataType == GL_FLOAT ||
> +             info->DataType == GL_NONE);
>  
>        if (info->BaseFormat == GL_RGB) {
>           assert(info->RedBits > 0);
> 
> _______________________________________________
> mesa-commit mailing list
> mesa-commit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-commit
> 


More information about the mesa-dev mailing list