[Mesa-dev] About merging pipe-video to master

Christian König deathsimple at vodafone.de
Tue Jul 12 05:34:01 PDT 2011


Am Dienstag, den 12.07.2011, 13:06 +0200 schrieb Henri Verbeet:
> 2011/7/11 Christian König <deathsimple at vodafone.de>:
> > So what do you guys think about it?
> >
> I didn't look much at the rest of the changes, but some of the changes
> for r600g (diff attached) look a bit questionable. Could you take a
> look at those to see if they're really all intentional and correct
> before merging?
Already discussed those changes a bit with Alex, and double checked that
it works with my available hardware (no piglit regressions). The changes
to the winsys code is about making a bo optional, even when the reg
informations says it isn't. This is useful for registers where only a
subset of the bits needs to be informed about a bo relocation, and seems
to work pretty fine as long as you don't touch those bits.

On top of that it implements "clamp_fragment_color" also for the blender
state, this is necessary because the blender will otherwise clamp the
colour to [0,1] for unsigned and [-1,1] for signed buffers.

This is another piece needed to get arb_color_buffer_float working
correctly (without the need to recompile the shaders each time).

Should I make a separate patch of this or is it ok to just merge it with
the branch? 

Regards,
Christian.



More information about the mesa-dev mailing list