[Mesa-dev] [PATCH] mesa: remove depend files from tarballs

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/19/2011 02:09 PM, Brian Paul wrote:
> On 07/19/2011 02:40 PM, Ian Romanick wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 07/19/2011 08:29 AM, Brian Paul wrote:
>>
>> Won't this add an extra dependency (on makedepend) in the tarballs?  I
>> thought that was the reason for including the empty depend files in the
>> first place.  Right?
> 
> It shouldn't make any difference since when the makefiles include the
> depend files we use "-include depend" (don't error if file is missing). 
> We pretty much require GNU make nowadays.  When we used to care about
> other versions of make we couldn't use "-include" everywhere and we'd
> crap out if "include depend" failed.
> 
> Also, I found that we weren't including a complete set of depend files
> in the tarball anyway.

I just noticed that as well.  I'm going to put my Reviewed-by on your
patch and put it in RC2.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk4mGJ4ACgkQX1gOwKyEAw8wsQCggWyw1VUjJLvzrr6DGmPeHp0p
dmYAnj60KlyJOwmjZXdpwCvhY8xlAibm
=5N56
-----END PGP SIGNATURE-----