[Mesa-dev] [PATCH] mesa: fix format selection for meta CopyTexSubImage()

Eric Anholt eric at anholt.net
Thu Jul 28 13:20:51 PDT 2011


On Thu, 28 Jul 2011 09:54:04 -0600, Brian Paul <brianp at vmware.com> wrote:
> When we do a glReadPixels into the temporary buffer, we don't want to
> use GL_LUMINANCE, GL_LUMINANCE_ALPHA or GL_INTENSITY since they will
> compute L=R+G+B which is not what we want.
> 
> This bug has existed all along but was only exposed by the elimination
> of the driver hook for glCopyTexImage() in
> 5874890c26f434f54e9218b83fae4eb8175c24e9.
> 
> Fixes https://bugs.freedesktop.org/show_bug.cgi?id=39604

Looks like a mostly-better restoration of
296e6b9038131cd246226881208ffebe3c2683c3, except without the check for
whether what we're reading from is the same base format already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110728/54520c20/attachment.pgp>


More information about the mesa-dev mailing list