[Mesa-dev] [PATCH] faster logbase2() - again

Roland Scheidegger sroland at vmware.com
Wed Jun 8 13:08:05 PDT 2011


Looks good to me - but skip the special n <= 1 case that's what the
(n|1) input to the __builtin_clz is good for.
Oh and I didn't notice before but there's an error in the gcc version
check (as that's defined as (__GNUC__ * 100 + __GNUC_MINOR__) - we're
ignoring patchlevel). Though as said there's the popcount usage right
next to it which doesn't do a version check neither - if that's the only
thing requiring gcc 3.4 we should fix that otherwise could just make gcc
3.4 a requirement.

Roland

Am 08.06.2011 21:44, schrieb Benjamin Bellec:
> On a Roland Scheidegger idea!
> 
> Benjamin
> 
> 
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev



More information about the mesa-dev mailing list