[Mesa-dev] [PATCH] mapi: Fix tls with shared/es-glapi on x86-64

Chia-I Wu olvaffe at gmail.com
Fri Jun 10 17:17:39 PDT 2011


On Wed, Jun 8, 2011 at 10:07 PM, Benjamin Franzke
<benjaminfranzke at googlemail.com> wrote:
> 2011/6/7 Chia-I Wu <olvaffe at gmail.com>:
>> How is that the case?  It seems the symbol is not used elsewhere.
>>
>
> Right, seems i tried solve the wrong side of the problem.
>
> x86_64_entry_start is declared similar to a global static variable in
> the asm code,
> so it will be bound local.
> But in entry_get_public its declared as extern, the compiler will generate code
> to lookup a global object, not a local.
> By declaring x86_64_entry_start as static the correct local address is
> loaded here.
I got this warning after applying the patch

  ../../../src/mapi/mapi/entry_x86-64_tls.h:69:1: warning:
‘x86_64_current_tls’ used but never defined

Maybe the function declaration should be decorated with "extern"?
> Patch attached.
>



-- 
olv at LunarG.com


More information about the mesa-dev mailing list