[Mesa-dev] [PATCH] i965/fs: Check for compilation failure and bail as soon as possible.
eric at anholt.net
Fri Jun 10 19:13:45 PDT 2011
On Fri, 10 Jun 2011 16:07:31 -0700, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Prior to this patch, it would happily continue compiling and even
> optimizing after a failure was detected. This seems wasteful.
> More importantly, the "message length > 11" failure seems to choke the
> instruction scheduler, making it somehow use an undefined value and
> segmentation fault.
Odd to have it inside that loop -- if it needs to be in there (instead
of just outside afterwards), that would indicate that that check needs
to be all over the place in the visitor. Pretty sure it doesn't need
mlen > 11 might have been an issue by overflowing a
16-entry-on-the-stack array in the scheduler
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
More information about the mesa-dev