[Mesa-dev] [PATCH] i965: fix mask used to write to clip distance registers when gen>6

Eric Anholt eric at anholt.net
Mon Jun 13 09:58:43 PDT 2011


On Sun, 12 Jun 2011 21:14:50 -0700, Paul Berry <stereotype441 at gmail.com> wrote:
> In gen6 and above, clip distances 0-3 are written to message register
> 3's xyzw components, and 4-7 to message register 4's xyzw components.
> Therefore when when writing the clip distances we need to examine the
> lower 2 bits of the clip distance index to see which component to
> write to.
> 
> emit_vertex_write() was examining the lower 3 bits, causing clip
> distances 4-7 not to be written correctly.

Reviewed-by: Eric Anholt <eric at anholt.net>

Is this caught by any new testcase?  It's not a requirement, just
thinking that since you were building testcases like this recently, it
might be easy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110613/cf0b94bd/attachment.pgp>


More information about the mesa-dev mailing list