[Mesa-dev] [PATCH 0/3] Removing unnecessary flushes in Gallium

Keith Whitwell keithw at vmware.com
Thu Mar 10 11:51:15 PST 2011


On Thu, 2011-03-10 at 20:25 +0100, Marek Olšák wrote:
> Hi,
> 
> I have reviewed where we call flush() and why and some of them
> seem unnecessary to me. Those flushes may slightly decrease
> performance, depending on each driver, and may hide driver bugs.
> 
> glFlush doesn't have to be called in OpenGL so often, and
> I think state trackers should follow suit.
> 
> The worst example of this is st/vega. I guess those flushes are
> there for debugging only.
> 
> Please review.

This all makes sense to me Marek.  I think some of those flushes predate
even is_resource_referenced() which explains their defensive nature.

Keith



More information about the mesa-dev mailing list